Add mesh conformance tests for httproute port and scheme redirect #3776
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
LiorLieberman
force-pushed
the
httproute-redirect-mesh-tests
branch
from
2c64c87 to
a88271b
Compare
|
/retest |
|
/cc @kflynn |
| MeshConformanceTests = append(MeshConformanceTests, MeshHTTPRouteRedirectPort) | ||
| } | ||
|
|
||
| var MeshHTTPRouteRedirectPort = suite.ConformanceTest{ |
There was a problem hiding this comment.
I think I missed this from the earlier conversations, but what's the plan to make these tests more sustainable + maintainable? Would it be viable to just have a simple script that did the copying and modification required for any tests that should be replicated for mesh? Is there a way to share the same test definitions for both?
There was a problem hiding this comment.
It would be a framework change. That is able to take the applicable test (probably using an enablement with a flag) and run it with a replaced parentRef and suite functions.
There was a problem hiding this comment.
Do we have any issues tracking that?
k8s-ci-robot
added
approved
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LiorLieberman
force-pushed
the
httproute-redirect-mesh-tests
branch
from
a88271b to
6fbbd90
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiorLieberman, robscott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
|
@LiorLieberman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/area conformance-test
Add mesh tests for port and scheme redirect
This is a follow up to #3729
What this PR does / why we need it:
Add mesh tests coverage
Which issue(s) this PR fixes:
Related #3581
Does this PR introduce a user-facing change?: